🚩PR: Added feature of dynamical accordion menu for filter, and added commit number for dev builds

intechstudio / profile-cloud

0 stars 0 forks source link

🚩PR: Added feature of dynamical accordion menu for filter, and added commit number for dev builds #66

Closed elsoazemelet closed 2 months ago

elsoazemelet commented 3 months ago

Closes #64 and #60

!!! USE EDITOR BUILD OF: https://github.com/intechstudio/grid-editor/pull/673

Added features

In a developer build of the ProfileCloud, in the left bottom corner (next to the build type and version number) a clickable link is added to the commit from which the build was made
This link opens in a new window
When searching a profile/preset in the ProfileCloud, if the currently selected profile is filtered out, the next available profile/preset is selected.
If this profile/preset is in a different category than the previously selected one, then the currently selected configs category is automatically opened

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit 7c4d4e1):

https://profile-cloud-dev--pr66-feat-commitandsearch-1pk3m3d4.web.app

_{(expires Tue, 16 Apr 2024 13:51:24 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2a004f867edf1347070dd9beedb18755187a6d4e}

elsoazemelet commented 2 months ago

[x] Fix search logic
[x] Remove comments
[x] Browser window should be opened not electron render
[x] BrowserView centered
[x] separate build date and version
[x] build env + build date + commit hash should be displayed in both views

narayb commented 2 months ago

Profile could categories no longer can be collapsed or opened. This is most likely caused by the changes to search logic.

When Firefox is my default browser, clicking on the build number doesn't open a new browser window, it only opens a new tab.

elsoazemelet commented 2 months ago

Profile could categories no longer can be collapsed or opened. This is most likely caused by the changes to search logic.

When Firefox is my default browser, clicking on the build number doesn't open a new browser window, it only opens a new tab.

Fixed in the latest commit. In web build mode, it should not open a new window, only a new tab.

narayb commented 2 months ago

Checked and fixed. Firefox worked the same way as last time, opening a new tab on clicking version number.