search

integer-net / Solr

Solr Module for Magento 1.
http://de.integernet-solr.com/
6 stars 0 forks source link

Search layer on https sites #9

Closed phizab closed 8 years ago

phizab commented 8 years ago

If I open a site via https, suggestions will be blocked by the browser because of mixed content. In IntegerNet_Solr_Helper_CatalogSearch_Data suggest url is "hard-coded" to unsecure base url. Is there any reason for this? What about calling suggest url via https every time?

avstudnitz commented 8 years ago

You are right, that's a bug. We will change that.

avstudnitz commented 8 years ago

Adjusted. @phizab could you test that?

phizab commented 8 years ago

The layer will be displayed now, this is good. But product images and product urls are still embedded via http, so my browser shows warnings. At least for images it should better be a https url, although the browser shows them.

Surely this gets a bit complicated when html code is stored in solr index. So I think there must be both a result html for http and https :-/ Or what do you think?

avstudnitz commented 8 years ago

Good question. Either that, or https only... the second is much simpler to archive. Would that be good enough?

phizab commented 8 years ago

I think https only (or rather secure base url only) should be good enough. The only disadvantage I see is the lower performance of the protocol, but this does not matter to me.

avstudnitz commented 8 years ago

Added with b07130a for skin, media, js URLs. Should do the job. Please try.

phizab commented 8 years ago

Seems to work very well, there aren't any notices in my browser anymore!