search

integr8ly / application-monitoring-operator

Operator for installing the Application Monitoring Stack on OpenShift (Prometheus, AlertManager, Grafana)
Apache License 2.0
30 stars 44 forks source link

update prometheus resource links #101

Closed laurafitzgerald closed 4 years ago

laurafitzgerald commented 4 years ago

Why Prometheus Operator CRDs file names have changed.

Verification Install - there should be no server reported 404 Not Found, status code=404 seen

R-Lawton commented 4 years ago

Ill verify this since Peter is out on PTO

laurafitzgerald commented 4 years ago

@david-martin sure I can do that. We also import crds from the Grafana Operator. To be consistent should we also do it for those resources?

david-martin commented 4 years ago

@laurafitzgerald Yes, let's do those too

laurafitzgerald commented 4 years ago

Hey @david-martin turns out the file names have changed since v0.34.0 of the prometheus operator. So if we're locking the version down, we need to stick with the older version of the file name. When we update the version, the file names would then need to be updated. Do you still want to go ahead with fixing the version?

david-martin commented 4 years ago

Do you still want to go ahead with fixing the version

Yes, locking it down now while we're familiar with the problem makes sense.

laurafitzgerald commented 4 years ago

@david-martin @R-Lawton This is pr is ready for review again. I did ask a more general question about the templates for grafana/prometheus in chat but trying to keep this change small for now.

R-Lawton commented 4 years ago

/lgtm i dont have approve rights tho so @david-martin will have to do that

david-martin commented 4 years ago

Thanks @laurafitzgerald