integr8ly / application-monitoring-operator

Operator for installing the Application Monitoring Stack on OpenShift (Prometheus, AlertManager, Grafana)
Apache License 2.0
30 stars 44 forks source link

service and rule selectors removed #103

Closed obrienrobert closed 4 years ago

obrienrobert commented 4 years ago

Description

https://issues.redhat.com/browse/INTLY-3137?focusedCommentId=13820290&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13820290

Once this is verified and merged, another PR will be created for the integreatly-operator which incorporates the removal of the monitoring-key label from individual resources.

Prerequisites

Verification

R-Lawton commented 4 years ago

verifying now

R-Lawton commented 4 years ago

verification steps worked looks good to me Screenshot from 2019-12-20 09-58-25

david-martin commented 4 years ago

@obrienrobert As discussed in person, lets go for the any: true approach as the serviceMonitorSelector and ruleSelector have to be set in order for prom operator to manage the config secret. The verification steps should probably be the same as what you did locally to test the values