integr8ly / application-monitoring-operator

Operator for installing the Application Monitoring Stack on OpenShift (Prometheus, AlertManager, Grafana)
Apache License 2.0
30 stars 44 forks source link

Fix Markdown link format in README #142

Closed tadayosi closed 4 years ago

tadayosi commented 4 years ago

In some links of form [...](...) in README the url and label are put the opposite way around, so the links are not correctly rendered . Also it adds a label to a raw url so it looks a bit prettier.

openshift-ci-robot commented 4 years ago

Hi @tadayosi. Thanks for your PR.

I'm waiting for a integr8ly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tadayosi commented 4 years ago

/assign @david-martin

david-martin commented 4 years ago

Thanks @tadayosi Good catch

david-martin commented 4 years ago

/approve /lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/integr8ly/application-monitoring-operator/blob/master/OWNERS)~~ [david-martin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment