search

integr8ly / application-monitoring-operator

Operator for installing the Application Monitoring Stack on OpenShift (Prometheus, AlertManager, Grafana)
Apache License 2.0
30 stars 44 forks source link

MGDAPI-236 #149

Closed CathalOConnorRH closed 3 years ago

CathalOConnorRH commented 3 years ago

implement priorityClass by adding priorityClassName managed-service-priority to the statefulSet pod spec

pmccarthy commented 3 years ago

@CathalOConnorRH @obrienrobert can this be merged?

obrienrobert commented 3 years ago

@CathalOConnorRH @obrienrobert can this be merged?

@pmccarthy I discussed this with @pb82 earlier today. Before it can be merged the Grafana Operator needs to be updated to 3.6.0 and the priority class name needs to be added to the CR.

pb82 commented 3 years ago

@CathalOConnorRH @briangallagher the AMO does currently not work when installing it outside of RHMI. The reason is that the CRDs use Status as a subresource, but the controllers do not use .Status().Update(): https://github.com/integr8ly/application-monitoring-operator/blob/master/deploy/crds/applicationmonitoring.integreatly.org_applicationmonitorings_crd.yaml#L13 vs https://github.com/integr8ly/application-monitoring-operator/blob/420e778a34a42ac3aa7ec5182da30e86bd07fa97/pkg/controller/applicationmonitoring/applicationmonitoring_controller.go#L762

I think we should fix this, maybe not in this PR but in general as there are Teams that still use the AMO to deploy a monitoring stack.

obrienrobert commented 3 years ago

Verified the priorityClassName is added successfully to both the Prometheus and Alertmanager statefulSets:

pod_priority_alertmanager

obrienrobert commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pb82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/integr8ly/application-monitoring-operator/blob/master/OWNERS)~~ [pb82] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment