integr8ly / application-monitoring-operator

Operator for installing the Application Monitoring Stack on OpenShift (Prometheus, AlertManager, Grafana)
Apache License 2.0
30 stars 44 forks source link

skip service account creation in grafana and bump AMO version #159

Closed briangallagher closed 3 years ago

briangallagher commented 3 years ago

What See JIRA INTLY-10438:

Skip the Service Account creation in the Grafana Operator. Instead it will be only created by AMO. This will prevent the OLM pod error which is the continuous updating of the resource leading to resource spikes.

Verify Install the AMO Operator and ensure it works as expected.

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign pb82 after the PR has been reviewed. You can assign the PR to them by writing /assign @pb82 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/integr8ly/application-monitoring-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
briangallagher commented 3 years ago

@CathalOConnorRH Can you review

CathalOConnorRH commented 3 years ago

/lgtm verified on clusters and images matched as expected

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pb82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/integr8ly/application-monitoring-operator/blob/master/OWNERS)~~ [pb82] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pb82 commented 3 years ago

LGTM

CathalOConnorRH commented 3 years ago

/lgtm