search

integr8ly / application-monitoring-operator

Operator for installing the Application Monitoring Stack on OpenShift (Prometheus, AlertManager, Grafana)
Apache License 2.0
30 stars 45 forks source link

Prepare release 1.7.0 - Add token to Blackbox Exporter ConfigMap #170

Closed carlkyrillos closed 2 years ago

carlkyrillos commented 2 years ago

Description

Version bump to 1.7.0 that fixes the Endpoint Detailed dashboard that would incorrectly show the grafana UI endpoint as down. This bugfix adds a ServiceAccount with namespace:get permissions and adds the ServiceAccount's token to the Blackbox Exporter ConfigMap so the Blackbox probe requests can reach the grafana endpoint that is behind a proxy.

JIRA: https://issues.redhat.com/browse/MGDAPI-2282

Verification

  1. Create a new OSD cluster via OpenShift and target it once it has finished provisioning.
  2. Pull this PR from the integreatly-operator repo and change this line to point to the image stored in my Quay repository: image: quay.io/ckyrillo/application-monitoring-operator:v1.7.0
  3. Install RHOAM from the command line to the remote cluster using the PR from Step 2.
  4. Once the installation is complete, verify that the "grafana-ui UP/DOWN Status" panel in the Endpoint Dashboard from the redhat-rhoam-middleware-monitoring-operator grafana route correctly displays that the grafana service is UP.

Screenshot of the dashboard without the bugfix: MGDAPI-2282-bug

Screenshot of the dashboard with the bugfix: MGDAPI-2282-bugfix

Type of change

Checklist

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign pb82 after the PR has been reviewed. You can assign the PR to them by writing /assign @pb82 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/integr8ly/application-monitoring-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
carlkyrillos commented 2 years ago

/retest

jackdelahunt commented 2 years ago

image

/lgtm

carlkyrillos commented 2 years ago

/assign @pb82 Could you take a look at this PR when you get a chance?