search

integr8ly / application-monitoring-operator

Operator for installing the Application Monitoring Stack on OpenShift (Prometheus, AlertManager, Grafana)
Apache License 2.0
30 stars 44 forks source link

Prepare release 1.8.1 - Re-adding ClusterRole for Blackbox ServiceAccount that was removed #171

Closed carlkyrillos closed 3 years ago

carlkyrillos commented 3 years ago

Description

The ClusterRole for the blackbox-service-account (originally added in version 1.7.0) was removed when AMO was bumped to 1.8.0. This PR adds the ClusterRole back into the CSV.

JIRA: https://issues.redhat.com/browse/MGDAPI-2282

Verification

  1. Create a new OSD cluster via OpenShift and target it once it has finished provisioning.
  2. Pull the changes from this PR and apply the new ClusterRole and ClusterRoleBinding to the remote cluster: oc apply -f application-monitoring-operator/deploy/cluster-roles/blackbox-exporter-clusterrole.yaml oc apply -f application-monitoring-operator/deploy/cluster-roles/blackbox-exporter-clusterrole_binding.yaml
  3. Replace this line in integreatly-operator to point the image stored in my Quay repository: image: quay.io/ckyrillo/application-monitoring-operator:v1.8.1
  4. Install RHOAM from the command line to the remote cluster using the PR from Step 3.
  5. Once the installation is complete, verify that the "grafana-ui UP/DOWN Status" panel in the Endpoint Dashboard from the redhat-rhoam-middleware-monitoring-operator grafana route correctly displays that the grafana service is UP.

Screenshot of the dashboard without the bugfix: MGDAPI-2282-bug

Screenshot of the dashboard with the bugfix: MGDAPI-2282-bugfix

Type of change

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign grdryn after the PR has been reviewed. You can assign the PR to them by writing /assign @grdryn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/integr8ly/application-monitoring-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
matskiv commented 3 years ago

The fixed CSV looks good to me. I don't think we necessarily need to retest it fully, as we are just putting back an already tested ClusterRole which was present in 1.7.0. So I will merge this and run the release pipeline.