integr8ly / installation

Integreatly Installer
83 stars 91 forks source link

enmasse messageuser resource not created during installation #674

Open secondsun opened 5 years ago

secondsun commented 5 years ago

Description

The messaginguser custom resource type is not created when you install from master.

Expected Behavior

When enmasse is installed, there should be a api-resource "Messagingusers" created in the cluster.

Actual Behavior

In 1.3 this resource is created, in master and 1.4 rc9 it is not.

Environment

RHPDS Openshift workshop cluster with integr8ly installation from master.

Steps to reproduce

Install integr8ly from master on RPHDS's Openshift workshop cluster. run oc api-resources and not that there is not a messageusers resource

odra commented 5 years ago

Opened an issue in enmasse repo: https://github.com/EnMasseProject/enmasse/issues/2869

maleck13 commented 5 years ago

Do we know what the impact of this is? Does it effect the usage of AMQ Online 1.1?

secondsun commented 5 years ago

To use enmasse/AMQ-Online you create addresses and address spaces secured by a message user. Without the messageuser api-resource we can't create the message user instances.

At least that's my understanding.

maleck13 commented 5 years ago

Hmm ok so wondering how the walkthrough can work (as it clearly must have during testing).

secondsun commented 5 years ago

Either a) the tests don't test this use case or b) since this was created before but stopped being created in the recent rc's we haven't hit it yet.

secondsun commented 5 years ago

or c) something has changed that I'm not aware of

secondsun commented 5 years ago

When I deploy the workshop in RHPDS the messaginguser resource is there to be used. However when I run the installer with 1.4rc9 it isn't there. If the testing is upgrading from 1.3 to 1.4rcX then the resource will still be there as it isn't removed Which would also explain why tests pass.

secondsun commented 5 years ago

@maleck13 So these resources still aren't being provisioned in the 1.4.0.

They don't affect the workshops because I don't think the workshops use them. However they are used by enmasse for controlling access to queues. Have message users been replaced with another mechanism or are all queues accessible to anything on the cluster?

darahayes commented 5 years ago

Do we know what the impact of this is? Does it effect the usage of AMQ Online 1.1?

Just to add to @secondsun's answer the impact of this is that it's not possible to create users using the approach recommended by enmasse and AMQ Online documentation.

My understanding is that by default, you cannot connect to a queue and consume messages without a user.

I'm not sure how the walkthrough creates the user but I'm thinking it's done through the service catalog -> Goes to the AMQ service-broker -> Perhaps that makes some direct API call to the AMQ api-server?

My suspicion is that the walkthrough and the tests are relying on creating the resources using the service catalog route which possibly circumvents the need for the appropriate API resources to be defined and that's why it wasn't caught in the tests.

Potential work around

Create an address space in your desired namespace using the service catalog.

I've just tested this in a 1.4 cluster and it works. This workaround has some problems that leaves AMQ Online on Integreatly unusable for any real world applications though.

Potential Next Steps

With the end goal being:

maleck13 commented 5 years ago

I have created a JIra to track https://issues.jboss.org/browse/INTLY-2490