Broker improvements api updates - Githubissues

integr8ly / managed-service-broker

Broker that allows services to be provisioned in a users namespace but sets up the service in another namespace

2 stars 14 forks source link

Broker improvements api updates #24

Closed sedroche closed 5 years ago

sedroche commented 5 years ago

Motivation

Re: This comment There is some refactoring and bug fixes that were in a couple of branches. See => https://github.com/integr8ly/managed-service-broker/pull/9 and https://github.com/integr8ly/managed-service-broker/pull/19 so this PR aggregates them all. (The commits from https://github.com/integr8ly/managed-service-broker/pull/19 is all the non ManagedServiceNamespace stuff)

What

README updates for tests
Match the service broker API spec for handling errors, naming etc.
Simplified the APIs as we kept adding parameters which was getting unmanageable.
Test suite updates
Update fuse deployer lastOperation to work from the fuse CR instead of pods

Verification Steps

https://github.com/integr8ly/managed-service-broker/tree/broker-improvements-api-updates#integration-tests

I will rebase https://github.com/integr8ly/managed-service-broker/pull/19 and close https://github.com/integr8ly/managed-service-broker/pull/9 once this lands

sedroche commented 5 years ago

@maleck13 Can this be merged? It needs constant rebasing since it contains API changes etc.

Code has been reviewed in https://github.com/integr8ly/managed-service-broker/pull/9 and https://github.com/integr8ly/managed-service-broker/pull/19 as per the PR description