search

integr8ly / managed-service-broker

Broker that allows services to be provisioned in a users namespace but sets up the service in another namespace
2 stars 14 forks source link

Add monitoring label to fuse namespaces #32

Closed sedroche closed 5 years ago

sedroche commented 5 years ago

Motivation

https://issues.jboss.org/browse/INTLY-798

Adding the required monitoring label ("monitoring-key": "<MONITORING_KEY_PARAM>") to the fuse namespaces

Verification Steps

[root@bastion evals]# oc describe namespace fuse-ecd6e1c4-261e-11e9-87e5-0a580a010007
Name:         fuse-ecd6e1c4-261e-11e9-87e5-0a580a010007
Labels:       monitoring-key=middleware
Annotations:  alm-manager=operator-lifecycle-manager.olm-operator
              openshift.io/sa.scc.mcs=s0:c11,c10
              openshift.io/sa.scc.supplemental-groups=1000130000/10000
              openshift.io/sa.scc.uid-range=1000130000/10000
Status:       Active
david-martin commented 5 years ago

"application-monitoring":"true"

This is actually now monitoring-key:middleware. We may need to allow the value middleware to be changed per cluster in future, so it's worth thinking about parameterising this in the msbroker install

sedroche commented 5 years ago

@david-martin have added a Param for this label. If you are happy with this i'll create the accompanying installer changes

sedroche commented 5 years ago

@philbrookes https://github.com/integr8ly/managed-service-broker/pull/32/commits/4ada241d725b79e7223843b36f123319a84e08bf