Intly 701 externalise fuse resources

integr8ly / managed-service-broker

Broker that allows services to be provisioned in a users namespace but sets up the service in another namespace

2 stars 14 forks source link

Closed mikenairn closed 5 years ago

mikenairn commented 5 years ago

Externalise fuse resources to allow easier upgrading to newer versions.
Fuse operator resources are now pulled from the fuse install repo, url is set via an env var (FUSE_OPERATOR_RESOURCES_URL)

Jira:

sedroche commented 5 years ago

:eyes:

mikenairn commented 5 years ago

This change looks how I would have expected it to. Do you know why there were so many vendor changes?

@maleck13 The openshift libs were updated https://github.com/integr8ly/managed-service-broker/pull/33/commits/cb67b92903db1b070e8c744cdd9b39155df6b5f7#diff-836546cc53507f6b2d581088903b1785 (3.9 -> 3.11). This was done on one of many iterations trying to get stuff to work, and probably isn't really required, but left it in as we should probably be using the newer versions anyway.

sedroche commented 5 years ago

Tested locally and looks good. Tests are good

tests passed
ok      github.com/integr8ly/managed-service-broker/tests   154.256s

Couldn't verify on PDS as https://issues.jboss.org/browse/INTLY-879 stopped me but the change is deployed to https://master.sedroche-eaaa.openshiftworkshop.com if you want to check it