Closed mfrances17 closed 5 years ago
Currently, all background images are also given a default color (resembling the main color of the image), in order to provide something other than a white background while the image loads.
To test the speed at which the images appear, you can set the Chrome Developer Tools to run over a 3g network.
@bdellasc - is this something where you want to just supply smaller logos or compress them more?
I guess some guidance on dimensions would be helpful. I believe I made them larger physical dimensions and higher resolution to render on hi-res screens. Maybe we can do some side-by-side tests to see what would be least visually detrimental to the image quality and give us better loading speeds? I can work with you next week on that.
After talking with Brian, it was determined that images matching the dimensions found here: https://github.com/patternfly/patternfly-next/tree/master/static/assets/images under pfbg_###.jpg
are needed.
These images would then translate into CSS that would render the different sized images based on media queries, targeting both viewport size, pixel ratio (1x vs 2x), and resolution DPI.
@mindreeper2420 - I did a first pass on the images, but was unhappy with how the pattern band scaled for some sizes. I'm going to spend some time cleaning them up before I post them for consumption.
@mindreeper2420 try these out
Completed with the merge of the referenced PR.
Originated from the UXD Team Feedback table: https://docs.google.com/document/d/1_AhqX8rPaZ2mfO-cI4lkhGbJLKLTWpo4HcCJ_KRhDjM/edit#heading=h.bjkplule4p3l
Loading time on success state is a bit slow - is there any way to speed this up?
Look at optimizing the background images so they load quicker (maybe just try progressive load, at the very least)