search

integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36 stars 54 forks source link

Use Monospace font for copy field #508

Closed johnfriz closed 5 years ago

johnfriz commented 5 years ago

Motivation

https://issues.jboss.org/browse/INTLY-3393 Font used in code blocks in Solution Explorer is not monospace

What

Add font-family: monospace; to the .integr8ly-copy-display class

Why

So that the font will be monospace

How

Add font-family: monospace; to the .integr8ly-copy-display class

Verification Steps

View any code block and ensure the font is monospace

Checklist:

Progress

Additional Notes

Before: Screenshot 2019-09-11 13 31 34

After:

Screenshot 2019-09-11 13 45 44
AdamJ commented 5 years ago

@tiffanynolan Can you take a look? PatternFly 4 uses Overpass for the copy/clipboard component but since we reverted that component update, we're using the old font styling. If changed, it might be worthwhile to update the designs as well?

aidenkeating commented 5 years ago

@finp @johnfriz If this is needed in 1.5 and we're happy with the changes, can we merge and I'll go through the various version bumping processes with @finp to get this into a release