integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36 stars 54 forks source link

Fixes dependency security issues related to INTLY-1078 #515

Closed dlabaj closed 4 years ago

dlabaj commented 4 years ago

Motivation

Fix for security dependency issues in repo

Verification Steps

  1. yarn install
  2. yarn build
  3. yarn test
  4. yarn start:dev
  5. Verified that application still function the same and there where no regressions.

Checklist:

Progress

Additional Notes

This is just the security fixes for the INTLY-1078. PF3 still needs to be removed as part of that issue.

mfrances17 commented 4 years ago

yarn install, yarn build, yarn test all passed

Seeing many new warnings introduced that didn't exist before, all are related to componentWillMount, componentWillReceiveProps, and componentWillUpdate that are used in a few different components. These are redisplayed in the console on each navigation.

Not seeing any regressions in appearance or behavior of the app.

dlabaj commented 4 years ago

@mfrances17 Good catch. I reverted to 16.6.3 and those warnings are gone now.