search

integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36 stars 54 forks source link

Valid GitHub repository URL fails validation in Application Settings #533

Closed abkieling closed 4 years ago

abkieling commented 4 years ago

Description

In the Application settings page, entering a GitHub repository URL with host github.com fails validation.

Expected Behavior

Validation shouldn't fail.

Actual Behavior

Validation fails.

Environment

Red Hat Solution Explorer Integreatly Version: release-1.5.2 Console Version: 2.18.7 User Name: customer-admin Browser Version: chrome 78.0.3904 Browser OS: Linux

Steps to reproduce

  1. Navigate to the Solution Explorer.
  2. Click the gear icon in the top right to display the Application settings screen.
  3. Enter the following URL: https://github.com/integr8ly/walkthrough-template.git
evanshortiss commented 4 years ago

@akieling try https://www.github.com/integr8ly/walkthrough-template.git as a workaround.

abkieling commented 4 years ago

Yep. I did that. By the way, I'll try to fix it and send a PR, OK?

mfrances17 commented 4 years ago

Do you mean it fails validation on the page? I fixed that issue a while back. And I just used that URL and it passes validation on the page and it shows up on the home screen.

abkieling commented 4 years ago

The issue happens in the Integreatly Workshop available on RHPDS.

tutorial-web-app-webapp apps abrianik-2e27 open redhat com_settings

abkieling commented 4 years ago

I've run tutorial-web-app locally and the issue seems to be fixed. Closing the issue.

mfrances17 commented 4 years ago

Yeah, mine is running on RHPDS, and I don't get the error since my fix... are you using an old version?

no-www

result

abkieling commented 4 years ago

Red Hat Solution Explorer Integreatly Version: release-1.5.2 Console Version: 2.18.7