search

integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36 stars 54 forks source link

Branding update #541

Closed christiemolloy closed 4 years ago

christiemolloy commented 4 years ago

Motivation

https://issues.redhat.com/browse/IUXD-74?jql=labels%20%3D%20integration-ux-dev%20AND%20assignee%20in%20(christiemolloy)

What

function added to masthead.js and aboutModal.js to return different logos depending on the cluster type.

Why

Logos need to be changed depending on the cluster type.

How

function added to masthead.js and aboutModal.js to return different logos depending on the cluster type.

Verification Steps

  1. Go to masthead.js
  2. Go to getLogo
  3. Add a new line to make the cluster type: poc osd pds localhost
  4. Check that the corresponding logos match the cluster type

Checklist:

Progress

Additional Notes

Screen Shot 2019-12-19 at 10 44 47 AM Screen Shot 2019-12-19 at 10 45 19 AM Screen Shot 2019-12-20 at 10 55 28 AM Screen Shot 2019-12-20 at 10 53 53 AM
tiffanynolan commented 4 years ago

Looking good. Just wanted to verify any changes to the About Modal as well for those logos too. Please refer to the prototype: https://marvelapp.com/1jjffegg/screen/63909572

christiemolloy commented 4 years ago

@dlabaj is there any way to determine which test is failing? Can't seem to tell from CircleCI

mfrances17 commented 4 years ago

@dlabaj is there any way to determine which test is failing? Can't seem to tell from CircleCI

@christiemolloy hey christie... i just approved a PR that should fix this issue. if you rebase and pull in that change the issue should be resolved.

christiemolloy commented 4 years ago

@mfrances17 I tried pulling in the latest but the tests still seem to failing