Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36
stars
54
forks
source link
INTLY-2830 - Fix webapp logout on os4 clusters #544
The deleteCurrentSessionAuthToken method was modified to return the promise to ensure the OauthAccessToken is deleted before logging out the user.
In addition, the SSO logout route is now configured to redirect to the root instead of to RHSSO logout as this would fail anyhow with a invalid_indirect errordue to missing client for this (not needed for this)
Verification Steps
OS4
Install integreatly
Run the webapp locally (point to an OpenShift cluster) or update your webapp deployment to use the image
Change image to quay.io/kevfan/tutorial-web-app-operator:v0.0.42
Run the ./scripts/setup-htpass-idp.sh to create sample users
Visit solution explorer and sign in / sign out ensuring there are no errors with the sign out
Note: There is an known issue where logging out using kubeadmin would sign the user back in. Just testing the users created from the script should be fine
OS3
Edit tutorial web app deployment config and use quay.io/kevfan/tutorial-web-app:2.20.10 as the container image.
Ensure user signin and signout still works as expected on an OS3 cluster
Checklist:
[ ] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by another team member
Motivation
Logout from the webapp is currently broken on OS4 cluster. This pull request fixes this bug allowing logout on OS4 clusters.
Jira:
Associated pull requests:
What
deleteCurrentSessionAuthToken
method was modified to return the promise to ensure theOauthAccessToken
is deleted before logging out the user.invalid_indirect error
due to missing client for this (not needed for this)Verification Steps
OS4
oc edit deployment tutorial-web-app-operator -n rhmi-solution-explorer
quay.io/kevfan/tutorial-web-app-operator:v0.0.42
./scripts/setup-htpass-idp.sh
to create sample usersOS3
quay.io/kevfan/tutorial-web-app:2.20.10
as the container image.Checklist: