integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36 stars 54 forks source link

INTLY-2830 - Fix webapp logout on os4 clusters #544

Closed KevFan closed 4 years ago

KevFan commented 4 years ago

Motivation

Logout from the webapp is currently broken on OS4 cluster. This pull request fixes this bug allowing logout on OS4 clusters.

Jira:

Associated pull requests:

What

Verification Steps

OS4

  1. Install integreatly
  2. Run the webapp locally (point to an OpenShift cluster) or update your webapp deployment to use the image
    • oc edit deployment tutorial-web-app-operator -n rhmi-solution-explorer
    • Change image to quay.io/kevfan/tutorial-web-app-operator:v0.0.42
  3. Run the ./scripts/setup-htpass-idp.sh to create sample users
  4. Visit solution explorer and sign in / sign out ensuring there are no errors with the sign out Note: There is an known issue where logging out using kubeadmin would sign the user back in. Just testing the users created from the script should be fine

    OS3

  5. Edit tutorial web app deployment config and use quay.io/kevfan/tutorial-web-app:2.20.10 as the container image.
  6. Ensure user signin and signout still works as expected on an OS3 cluster

    Checklist:

philbrookes commented 4 years ago

LGTM, but cannot verify ATM.

jjaferson commented 4 years ago

@philbrookes I am free to verify this

philbrookes commented 4 years ago

I am verifying this now.