integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36 stars 54 forks source link

INTLY-4959 - fix sorting service crashes on login on os4 #547

Closed KevFan closed 4 years ago

KevFan commented 4 years ago

Motivation

On OS4, login is broken due to the object returned when calling getServiceSortOrder() does not contain a spec object causing an undefined error and crashing the webapp on login

Jira:

What

Verification Steps

  1. Install integreatly on a OS4 cluster
  2. Scale down the web app operator to prevent it reconciling back to specified image
    • oc edit deployment tutorial-web-app-operator -n rhmi-solution-explorer
  3. Change image to quay.io/kevfan/tutorial-web-app:2.21.1 on tutoiral web app deployment config
    • oc edit deploymentconfig tutorial-web-app -n rhmi-solution-explorer
  4. Run the ./scripts/setup-htpass-idp.sh to create sample users
  5. Visit solution explorer and ensure you can sign in and sign out without errors with the created users Note: There is an known issue where logging out using kubeadmin would sign the user back in. Just testing the users created from the script should be fine

Checklist:

philbrookes commented 4 years ago

/lgtm /approved verified on my OSD cluster.