integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36 stars 54 forks source link

INTLY-7486: Point amq console links to the parent link instead of the address space link #583

Closed JameelB closed 4 years ago

JameelB commented 4 years ago

JIRA: https://issues.redhat.com/browse/INTLY-7486

This change ensures amq online url points to the parent console instead of address space on os3.

Reason for change The AMQ console route has changed from console-proxy to console in the new AMQ version 1.4. It's path to the address space also has a new format.

After upgrade from rhmi 1.6 to 1.7, the dashboardUrl in the address space of the service instance still remained pointing to the console-proxy route which is being used by the webapp to populate the amq console links in the managed services menu and within the walkthroughs.

This dashboardurl field is managed by the AMQ service broker itself and cannot be modified once created.

Instead of pointing to the address space itself, we should point to the 'parent' amq console link. This will enable us to no longer rely on the dashboardUrl field in the service instance. It will also allow us to ensure that the url to the amq console will always be correct on future versions if it changes again. The AMQ url will now be made available to the webapp through the INSTALLED_SERVICES field.

Related Walkthrough changes: https://github.com/integr8ly/tutorial-web-app-walkthroughs/pull/137

Verification steps

Installation

  1. Run the webapp locally and ensure you pass the following env var when running:
    INSTALLED_SERVICES='{   "amq-online-standard":{       "Host":"<amq-online-console-route>"  }}'

Verified on OSD OS3:

Before amq was provisioned: image

After amq was provisioned, each amq console link redirected you to the following url: https://console-openshift-enmasse.f2d1.rhmi-qe1.openshiftapps.com/#/address-spaces

This was also verified on OS4 by @pb82.

Changes did not affect routes in OS4. This change only affected the AMQ route on OS3.

WT1A was tested with the following PR: https://github.com/integr8ly/tutorial-web-app-walkthroughs/pull/137

Upgrade

Steps to verify changes on upgrade from RHMI 1.6 to 1.7:

Verified changes on upgrade from RHMI 1.6 to 1.7. WT1A still works, previously sent messages can still be seen in the order app. New messages can still be sent.

JameelB commented 4 years ago

ping @tiffanynolan