integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36 stars 54 forks source link

APPDUX-228: Fixes to incorporate latest PF4 breaking change release #596

Closed mfrances17 closed 4 years ago

mfrances17 commented 4 years ago

Motivation

https://issues.redhat.com/browse/APPDUX-228

What

Update to the latest Patternfly 4 build and make fixes so the UI behavior and look and feel work as expected.

Why

To incorporate the latest PF4 components going forward.

Verification Steps

Open Solution Explorer and traverse the entire UI to verify that no new issues were introduced.

Checklist:

Progress

Additional Notes

You can test effectively by pulling down this branch and running locally, but if you want to test on a server, you can use this docker image of the solution explorer:

docker.io/mfrances17/dev-tutorial-web-app:pf4-latest

Various screen caps: UI-pf4-1

UI-pf4-2

UI-pf4-3

UI-pf4-4

UI-pf4-5

UI-pf4-6

dlabaj commented 4 years ago

Lgtm

mfrances17 commented 4 years ago

@jenny-s51 @dlabaj @christiemolloy @pb82 @tiffanynolan Updated with the latest Patternfly 4 release... can be tested locally or on my server: https://solution-explorer.apps.cluster-uxddev-916c.uxddev-916c.example.opentlc.com/

tiffanynolan commented 4 years ago

Looking great! I noticed that the right side padding/gutter is missing from the data list. Can you add that back in? image

tiffanynolan commented 4 years ago

Also, there is some extra padding between the tab bar and the data list. Can this be removed? Current: image Desired: image

mfrances17 commented 4 years ago

Fixed the issues @tiffanynolan found, put an image of the latest on my server. Please have a look at your earliest convenience: https://solution-explorer.apps.cluster-uxddev-916c.uxddev-916c.example.opentlc.com/

Screen caps as well, for your convenience:

initial_page

settings_page