APPDUX-251: Incorrect backup time written for midnight - Githubissues

integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.

Apache License 2.0

36 stars 54 forks source link

APPDUX-251: Incorrect backup time written for midnight #600

Closed mfrances17 closed 4 years ago

mfrances17 commented 4 years ago

Motivation

https://issues.redhat.com/browse/APPDUX-251

What

Leading 0 was being added to 24hr time for midnight when writing daily backup times from the UI to the YAML (000:00 instead of 00:00).

Why

Bad algorithm needed to be fixed.

Verification Steps

On the Settings > Managed Integration schedule tab, select 12:00 am from the Start time for your backups dropdown and click Save.
View the rhmi-config YAML file and verify that the time is now saved as: applyOn: '00:00'

And is not saved as: applyOn: '000:00'

To view the YAML file:

Select Project: redhat-rhmi-operator
Click Home > Search
Select Resources > RHMIConfig
Click rhmi-config
Select YAML tab. Scroll down to see the applyOn time.

Checklist:

[x] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by another team member

Progress

[x] Finished task

Additional Notes

Can be tested live on my openshift cluster: https://console-openshift-console.apps.cluster-uxddev-916c.uxddev-916c.example.opentlc.com/

Or on any OS4 cluster using this solution explorer docker image: docker.io/mfrances17/tutorial-web-app:appdux-251

12am-settings

12am-rhmi-config