integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36 stars 54 forks source link

Adding info alerts to UI #602

Closed jenny-s51 closed 4 years ago

jenny-s51 commented 4 years ago

Motivation

https://issues.redhat.com/secure/RapidBoard.jspa?rapidView=4966&view=detail&selectedIssue=APPDUX-191

Issue to be extended by https://issues.redhat.com/browse/APPDUX-260.

What

WIP; Adds default alerts to Solution Explorer UI

Why

See JIRA link above.

How

Added new state variables: showSettingsAlert and showInfoAlert; implemented Alert components with onClose function on settings page and landing page.

Verification Steps

  1. Pull down code.
  2. On line 424 of settings.js, set let isAdmin = true;. Uncomment line 434.
  3. Start the app.
  4. See alert banner added on landing page.
  5. Close the alert and refresh the page. The alert should no longer show.
  6. Go to settings page.
  7. See alert banner added to settings page. Close the alert and refresh.

Checklist:

Progress

Additional Notes

Screen Shot 2020-07-14 at 3 42 55 PM Screen Shot 2020-07-14 at 3 43 08 PM
tiffanynolan commented 4 years ago

@phcox Can you provide some guidance on your expectations around when the notifications first appear, what user(s) these are applicable to, how often they would be displayed again, etc.?

Actually, I do see a lot of that info in the annotated designs. @jenny-s51 Have you had a chance to review those?

phcox commented 4 years ago

Hey, I'll give some guidance on behavior for these alerts in a separate comment, but first I want to confirm that these alerts are not going to be used in RHMI 2.5. The screen shot above shows them implemented in 2.5. These alerts were written for 2.6 when we provide all the scheduling capabilities - the text in these alerts refers to functions that we don't provide in 2.5. @tiffanynolan @mfrances17 @jenny-s51

phcox commented 4 years ago

The intent for the behavior of the alerts is as follows:

Information alerts (one below the masthead of the Solution Explorer page and one at the top of the Managed Integration schedule tab in Settings, both shown above)

Warning alert (issued when an Upgrade is pending)

Error alert (issued when a scheduled backup time overlaps the first hour of the maintenance window)

There may be instances in which two alerts can be displayed at once. This situation would occur if the user does not dismiss the information alerts. In these cases, the alerts should be stacked on the page, with the error / warning alerts presented on the top of the stack with 24 px vertical spacing between the two alerts.