Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36
stars
54
forks
source link
APPDUX-390: Fix for settings config not saving properly, and tab displaying on OS3 #608
Pulled some code that was added to poll rhmi config, was interfering with settings saving to the config. Also, a var that is used to force OS4 when testing locally was left uncommented, recommented so OS3 systems would hide the config tab.
Note that there is no new code to review, just removal of the watcher code that was added.
Verification Steps
On an OS4 system, go to settings > first tab.
Change any config settings value and click save. The rhmi-conifg YAML file should reflect that change.
Similarly, change any value in the rhmi-config and the UI should have those values (if refreshed).
On an OS3 system, go to settings. The first tab should be completely hidden, only the second tab (walkthrough repos) should be shown. Note that if you are not an administrator, no tabs will be shown, only a message about needed the correct admin rights.
Motivation
https://issues.redhat.com/browse/APPDUX-390
What
Pulled some code that was added to poll rhmi config, was interfering with settings saving to the config. Also, a var that is used to force OS4 when testing locally was left uncommented, recommented so OS3 systems would hide the config tab.
Note that there is no new code to review, just removal of the watcher code that was added.
Verification Steps
Checklist:
Progress
Additional Notes
Can be verified on my system as working: https://solution-explorer.apps.cluster-uxddev-9f0b.uxddev-9f0b.example.opentlc.com/
Or add this solution explorer docker image to your own server: docker.io/mfrances17/tutorial-web-app:APPDUX-390