search

integr8ly / tutorial-web-app

Solution Explorer provides the front door into the Integreatly initiative. It hosts the various Solution Patterns, as well as providing a dashboard of installed applications/products/services.
Apache License 2.0
36 stars 54 forks source link

APPDUX-379: Days of week should not be abbreviated #610

Closed mfrances17 closed 4 years ago

mfrances17 commented 4 years ago

Motivation

https://issues.redhat.com/browse/APPDUX-379

What

Design preferred long day names over abbreviations in the front end UI, despite the day names being in the short form on the back end and config files.

Why

Better usability.

Verification Steps

These steps can be performed on my cluster: https://solution-explorer.apps.cluster-uxddev-9f0b.uxddev-9f0b.example.opentlc.com/

Or on your own cluster using the following docker image: docker.io/mfrances17/tutorial-web-app:APPDUX-379

  1. Go to Settings > Managed Integration schedule.
  2. Verify that the days of the week dropdown displays days in the long form (Monday) vs short form (Mon).
  3. Choose a new day and click Save.
  4. Verify that the rhmi-config file is saved in the short from required by the backend. To do this, on OpenShift: a) Select redhat-rhmi-operator project. b) Click Home > Search. c) Click Resources > RHMIConfig. d) Click rhmi-config. e) Select the YAML tab.

Checklist:

Progress

Additional Notes

Screen cap of UI showing longer days of the week: saturday_ui

Screen cap of rhmi-config file after save: saturday_rhmicfg

phcox commented 4 years ago

LGTM

mfrances17 commented 4 years ago

I think the isOpen for each of these needs to be changed to any of isBackupOpen, isMaintDayOpen, isMaintTimeOpen

I'll take a look, thanks!