Fix issue #1 and consolidate controllers

integrallis / stripe_event

Stripe webhook integration for Rails applications.

https://rubygems.org/gems/stripe_event

MIT License

842 stars 105 forks source link

Fix issue #1 and consolidate controllers #3

Closed bousquet closed 11 years ago

bousquet commented 11 years ago

A more simplified take on a solution to Issue #1 from integrallis/stripe_event. I don't see any benefit to having these split up into a before filter and a single controller action. Specs pass and this has been tested against the Stripe test api for both unauthorized and successful webhook results.

travisbot commented 11 years ago

This pull request passes (merged e79650d7 into e2eb92cb).

invisiblefunnel commented 11 years ago

I'm :+1: on this. Can you make the event object a local variable and delete these redundant specs? After that I will review, merge, and cut a new release.

travisbot commented 11 years ago

This pull request passes (merged c104f923 into e2eb92cb).