integrated-application-development / delphilint

Delphi IDE package providing on-the-fly code analysis and linting, powered by SonarDelphi
GNU Lesser General Public License v3.0
79 stars 9 forks source link

DelphiLint fails when Delphi 11 is not installed #10

Closed mobius1qwe closed 5 months ago

mobius1qwe commented 5 months ago

Prerequisites

Delphi IDE version

12 Athens

DelphiLint version

1.0 Latest release

SonarDelphi version

1.3.0 default version

SonarQube version

No response

Issue description

image I have multiple delphi versions installed and I just

I have PATH overrides on Delphi IDE since its mandatory when you have multiple versions installed. Maybe DL isn't reading from that but is reading from windows' Path instead.

Steps to reproduce

Minimal Delphi code exhibiting the issue

No response

fourls commented 5 months ago

Hi, thanks for raising this issue.

This is caused by a silly typo - when DelphiLint tells SonarDelphi where the installation is, instead of setting sonar.delphi.installationPath, DelphiLint sets sonar.delphi.bds.path instead (the old name of the property). Since the property is unset, SonarDelphi defaults to the Delphi 11 installation path, hence this error when Delphi 11 is not installed.

That has stayed hidden for months because I have both Delphi 11 and Delphi 12 installed - I will fix this today and release a new patch version.

DelphiLint should work perfectly when multiple IDE versions are installed - there has been care to support that use case since we know it's a common one.

fourls commented 5 months ago

This issue is now resolved in DelphiLint 1.0.1.