Improve analysis and modeling around property specifiers - Githubissues

integrated-application-development / sonar-delphi

Delphi language plugin for SonarQube

GNU Lesser General Public License v3.0

104 stars 16 forks source link

Improve analysis and modeling around property specifiers #248

Closed Cirras closed 4 months ago

Cirras commented 5 months ago

The original goal of this PR was just to exclude properties with an implements specifier in the UnusedProperty rule.

It ended up doing a bit more than that:

Modeled all of the non-trivial property specifiers as proper AST nodes (default, implements, index, stored)
Fixed a bug where name resolution did not occur for type references in implements specifiers
Excluded properties with an implements specifier in UnusedProperty (easiest part...)
Fixed overly-permissive parsing rules where string and file were erroneously permitted anywhere that typeReference was allowed.