False positive in `UnusedVariable`

[zedxxx]

Delphi IDE version: Delphi 12.1

DelphiLint version: 1.1.0

SonarDelphi version: 1.6.0

unit Unit1;

interface

uses
  GR32,
  GR32_Polygons,
  GR32_VectorUtils;

procedure DrawThickPolyLine(ABitmap: TBitmap32; const APoints: TArrayOfFloatPoint;
  const AColor: TColor32; const AWidth: Integer);

implementation

procedure DrawThickPolyLine(ABitmap: TBitmap32; const APoints: TArrayOfFloatPoint;
  const AColor: TColor32; const AWidth: Integer);
var
  VPoly: TArrayOfFloatPoint;
begin
  VPoly := BuildPolyLine(APoints, AWidth);

  if not ABitmap.MeasuringMode then begin
    PolygonFS(ABitmap, VPoly, AColor);
  end;

  ABitmap.Changed(MakeRect(PolygonBounds(VPoly), rrOutside));
end;

end.

[Cirras]

Hi @zedxxx,

I can't seem to reproduce this UnusedVariable FP. (See image below)

Here's what I did:

• created a new VCL project
• cloned the Graphics32 library and added the Source folder to the search path in project options
• added your Unit1 file to the project
• built the project successfully (just to make sure it could compile)
• scanned with DelphiLint (FP issue not reproduced)

The analyzer requires source code to perform type & invocation resolution, and things can go quite haywire if dependency source code isn't in the search path (or debugger source path).

One potential thing - do you only have the Graphics32 DCUs on your search path, and not the source files?

[Cirras]

See: https://github.com/integrated-application-development/sonar-delphi/issues/250#issuecomment-2159971922