search

integrated-application-development / sonar-delphi

Delphi language plugin for SonarQube
GNU Lesser General Public License v3.0
104 stars 15 forks source link

Add support for the library path #267

Closed Cirras closed 4 months ago

Cirras commented 4 months ago

This PR adds support for the global library path.

All we had to do was grab the DelphiLibraryPath and DelphiTranslatedLibraryPath properties and append them to the DCC_UnitSearchPath to complete the search path. These properties are reflected from the registry to EnvOptions.proj by the IDE, which is how they become available to MSBuild and by extension the analyzer.

The nice thing is that 95% of the work for this was done a long time ago when we implemented comprehensive support for MSBuild project files.

Closes #254.

Cirras commented 4 months ago

Addressed your feedback points around the comment and changelog, what do you think?

My testing has mostly focused on the flow-through from the library path properties to the internal search path representation. A sanity check in the form of a high-level manual integration testing wouldn't go amiss.