search

integrations / microsoft-teams

Bringing your code and work to the conversations you care about with the GitHub and Microsoft integration
443 stars 97 forks source link

Url is tampered in preview card when the link unfurls in teams #179

Closed Abhiram219 closed 2 years ago

Abhiram219 commented 2 years ago

Describe the bug

When the Url is unfurled in teams by using link unfurling, in preview mode & is being converted to & As a result our page is beraking.

Example: When I paste a URL 'https://www.abc.com/ab?c=d&e=g' this url is being converted to 'https://www.abc.com/ab?c=d&e=g'

To Reproduce Steps to reproduce the behavior:

  1. Add compose extensions in manifest and make unfurling work in teams.
  2. Paste a valid link and minimize it into preview mode and send it.
  3. On clicking the preview card it takes to a new tab with tampered URL.
  4. Tampered URL can be found in the tooltip on hovering the preview card.

Expected behaviour The expected behaviour is to open with the pasted URL without being tampered

Screenshots

Screenshot 2021-12-02 at 10 36 00 AM

-- Above described behaviour can be seen in the image

Desktop (please complete the following information):

gauravsaralMs commented 2 years ago

@Abhiram219 this app/repo handles unfurl only for urls which are in github.com domain.

You can report your issue to MsTeams. Instructions