search

integrations / microsoft-teams

Bringing your code and work to the conversations you care about with the GitHub and Microsoft integration
443 stars 97 forks source link

Can't connect to EMU with desktop Teams client #205

Open dmeatte-aq opened 2 years ago

dmeatte-aq commented 2 years ago

Describe the bug The signin command won't allow you to authorize with an EMU account when using the desktop Teams client.

To Reproduce Steps to reproduce the behavior:

  1. Start the desktop Teams client.
  2. Open a chat with the @GitHub bot.
  3. Type signin in the chat.
  4. The bot will respond with a "Connect GitHub account" button. Click the button.
  5. The button opens a dialog that shows a "Connect GitHub account" button. Click it.
  6. The dialog now shows the normal GitHub sign in screen. There's no way to redirect it to the EMU url to authorize it with my SSO credentials.

Expected behavior The client should let me sign in with my EMU account like the web browser version does.

Desktop (please complete the following information):

Additional context This can be worked around by using https://teams.microsoft.com in the web browser to do the signin.

ashokirla commented 2 years ago

@snankani Can you please get the DRI to look into the issue.

dmeatte-aq commented 2 years ago

This may not be an issue. I don't know if this is a recent change, but currently, if I type in my emu username into the sign in dialog that the teams integration pops up, the sign in button at the bottom changes to "Sign in with your identity provider" and the password box is disabled. This does allow be to enable the integration. This feature seems to be enabled when the username contains an underscore. Interestingly enough, it seems that the username only needs to be _<emu name>. The first part of the user name isn't needed.

The fix for this may not be a code change, but an addition to the documentation. Typing in the username or the emu name isn't obvious solution for me.