search

integrations / microsoft-teams

Bringing your code and work to the conversations you care about with the GitHub and Microsoft integration
430 stars 95 forks source link

Reviewers section is not updated when changed on a pull request on GitHub #241

Closed brad-dawson closed 1 year ago

brad-dawson commented 1 year ago

Describe the bug

When a reviewer is added to a pull request, the "Reviewers:" section on the GitHub message in Microsoft Teams is not updated to reflect the changes.

To Reproduce Steps to reproduce the behavior:

  1. Ensure your channel connector is subscribed to the repository desired with pulls.
  2. Create a new pull request in GitHub.
  3. Notice the GitHub connector notifies the channel as desired.
  4. On GitHub, add a "Reviewer" to the pull required. 5.a. Actual: "Reviewers:" in teams is not updated. 5.b. Expected: "Reviewers:" in teams is updated with the newly added/removed reviewer.
  5. Complete the pull request. 6.a Notice the pull request's status is updated, but the reviewers is still not updated.

Expected behavior

When a reviewer is added/removed to the pull request on GitHub, the connector should update the "Reviewers:" with the reviewers assigned in the Microsoft Teams message.

Desktop (please complete the following information):

Additional context

I tried setting up the connector as well as viewing messages on both the native MacOS app, and within the Edge browser, both environments exhibited the same behavior.

sanjeev9160 commented 1 year ago

@bradcutshall I tried reproing the issue but it works for me. Can you please share the snapshots and also please clarify what do you mean by channel connector and GitHub connector Thanks.

brad-dawson commented 1 year ago

Channel connector /github connector is the tool that allows you to mention GitHub in the Microsoft Teams channel using @GitHub, ie. @GitHub subscribe org/repo

Example image:

image
sanjeev9160 commented 1 year ago

@bradcutshall Do you see it happening for all the PR notifications cards? As I am just guessing this may be due to some transient issues. Meanwhile I will try to check if there are any issues from our side. Thanks.

brad-dawson commented 1 year ago

@sanjeev9160 Thank you for looking into this issue! Yes, it happens to every PR notification card.

brad-dawson commented 1 year ago

@sanjeev9160 I don't know what changed, but as of today (3 Oct 2022) the reviewer is being assigned and updated correctly.