integrations / microsoft-teams

Bringing your code and work to the conversations you care about with the GitHub and Microsoft integration
430 stars 95 forks source link

Reviewers in Teams does not match Reviewers in GitHub #251

Closed brad-dawson closed 1 year ago

brad-dawson commented 1 year ago

Describe the bug All "Reviewers" are removed in teams when a PR is completed. However, in GitHub, the reviewer is still present on the PR. It seems expected that the reviewer should still be listed in the card on teams even after the PR is completed, since they are still assigned as a reviewer on the now merged PR. It's preferred that the teams card match the data in GitHub.

To Reproduce Steps to reproduce the behavior:

Expected behavior "Reviewers:" should match users assigned as reviewers in GitHub.

Screenshots image

Desktop (please complete the following information):

aasiddiq commented 1 year ago

@bradcutshall thank you for raising this issue. We have identified the issue and will push a fix soon for this.

brad-dawson commented 1 year ago

@aasiddiq Awesome, thank you!

aasiddiq commented 1 year ago

@bradcutshall Fix is now live. If you see any further issue feel free to reopen.

brad-dawson commented 1 year ago

@aasiddiq We ran into an issue with the reviewers. Two reviewers were added to the PR, and in teams it shows the two reviewers, plus the person who created the PR. However, where it gets more weird, the two reviewers and the person who created the PR were all added four more times.

For example in GitHub three users were involved, the user who created the PR and users A and B who were assigned as reviewers. On Teams, in the reviewers section, it showed: "Reviewers A, PR, A, A, A, A, A, B, PR, PR, PR, A".