search

integrations / microsoft-teams

Bringing your code and work to the conversations you care about with the GitHub and Microsoft integration
428 stars 95 forks source link

Changing Labels (by hand or from bot) dont trigger the +label filter in subscription #285

Open itd-pal opened 1 year ago

itd-pal commented 1 year ago

Describe the bug We want to split our incoming notification from Github depending which label is set/added. But if we or a bot add the subscribed label to a PR ist dont gets triggered and we don't get a message. Only if we add a comment the trigger works.

To Reproduce Steps to reproduce the behavior:

  1. Subcribe in two diffrent channels to two diffrent labels.
  2. Create a PR and add one of the subcribed Label

Expected behavior Also after setting or changing the label the message should be send

Screenshots

Desktop (please complete the following information):

Additional context

gurudattakamat9535 commented 1 year ago

Facing same issue

gurudattakamat9535 commented 1 year ago

hey @itd-pal if u get any solution just post it here

itd-pal commented 1 year ago

hey @itd-pal if u get any solution just post it here

My current workaround is that our automatic tests comment the results on the PR which triggers the label filter.

shruti-shukla commented 1 year ago

@itd-pal As I understand, the label is getting added after the PR is created and so the notifications are being missed. This is actually not a bug, but the current design. We don't process label edited events individually. Only if the PR is created with the label - the pull request event will contain the needed information that will be processed and notified.

itd-pal commented 1 year ago

@shruti-shukla Thanks for the clarification. Can you change the label of the issue to "Feature request" as it still would be nice that not only adding comments to the PR but also adding labels triggering the filter.

Thanks 🚀

arminnadarevic-cab commented 12 months ago

@shruti-shukla Thanks for the clarification. Can you change the label of the issue to "Feature request" as it still would be nice that not only adding comments to the PR but also adding labels triggering the filter.

Thanks 🚀

Are they any updates on this because this would be very helpful for us that are using auto labeling. We have a monorepo with the CODEOWNERS. Then we have an auto labeling based on that so that the correct team gets the message. As of now no PR will go until the PR is edited because the subscription is not triggered.

Thanks