search

integrations / microsoft-teams

Bringing your code and work to the conversations you care about with the GitHub and Microsoft integration
449 stars 101 forks source link

Comments not rendered correctly anymore #372

Open dscho opened 5 months ago

dscho commented 5 months ago

I cannot quite put my finger on when this started, or for that matter, what the exact conditions are when this happens, but I see a lot of these lately:

image

At first I thought that this must be issue comments only, as PR comments seem to be rendered correctly. But then I also saw some recent issue comments that were rendered incorrectly...

StanBJAVS commented 5 months ago

Comments on Pull Requests SEEM to work fine for me. Opening/Closing Issues with comments work fine for me. Comments ON open issues do not work.

Comments on Issues worked for me at 6/6/2024 @ 09:06AM EDT. Comments on Issues STOPPED working for me at 6/6/2024 @ 10:49AM EDT

alievrouw commented 5 months ago

I can confirm, this is happening for me as well. Comments on open issues is the one that is most frustrating. This is something that I used all day everyday.

javsjmoore commented 5 months ago

Edited comments show up for us but not new comments.

alievrouw commented 5 months ago

Edited comments show up for us but not new comments.

I also found that new comments that show up incorrectly have their message changed in-place if you delete the message.

dscho commented 5 months ago

I believe that this is now fixed, thanks to https://github.com/github/slack/pull/4503. Thank you @shashank19gaurav!