integrations / slack

Bring your code to the conversations you care about with GitHub's integration for Slack
https://slack.github.com/
MIT License
3.1k stars 489 forks source link

Slack notifications not working on mentions in comments on commits #1259

Open Birajpjpt opened 3 years ago

Birajpjpt commented 3 years ago

Describe the bug When a user is mentioned in the comments in any commits, they aren't being notified over the slack. They are however notified via email.

To Reproduce Steps to reproduce the behavior:

  1. Go to a new or any other commit
  2. Scroll all the way down and in write the comment section, add any comment while mentioning a user.
  3. The user isn't notified over slack for the mention

Expected behavior Any user mentions should've resulted in a slack notification real time.You are mentioned in a comment option within enable real time alerts is also properly checked.

amitkumariiit commented 3 years ago

@Birajpjpt I think its only supported for the mention in the comment on the pr. Keeping this for feature request.

IronSean commented 3 years ago

This should work for normal issue comments as well, or the wording should be updated to explain it is specifically a PR comment. It reads like any @mentions will cause a github notification currently. To clarify I'm looking for comments on normal issues, not on comments on commits.

Note: I'm experiencing this issue in the Github Reminders feature, not the github slack app. This might be the wrong PR for that?

user216 commented 2 years ago

when someone update existing comment - new notifications about those update not appeared in defined slack channel that is subscribed to comments

andnor commented 2 years ago

+1 to get real-time alerts for all mentions, including on issues and commits Also +1 that an update to an existing comment (to PR, issue, or commit) should trigger a new alert

aHagouel commented 1 year ago

+1 to slack notifications for issues -- my organization barely uses email and slack integration would make collaboration much faster

TziviElias commented 1 year ago

any update on this? Has anyone figured out how to receive Slack notifications for issues (not prs)?

daxmc99 commented 1 year ago

I use Zapier to create a zap to cover this missing functionality https://zapier.com/shared/1e8b590be3b8d18979d1d5491b8cc8d71494e418

noahsidney commented 1 year ago

+1 on this feature being fixed!

angalic commented 1 year ago

any update? according to the documentation this should work so this is actually a bug?

https://github.com/integrations/slack#mentions

angalic commented 1 year ago

a duplicate of this issue: #1669

tomharrisonjr commented 1 year ago

Same issue with commits to a branch -- no notifications. This seems like a bug, but guessing same issue as here with comments.

johnyaku commented 1 year ago

This used to work, but no longer. Perhaps GitHub has changed its API and broken the integration with Slack?

noudadrichem commented 11 months ago

I have the same thing. We get 0 notifications on comments on PRs, inline comments and comments on commits.

letiesperon commented 11 months ago

+1. I'm missing out on mentions in PRs. what's going on?

keithdoyle9 commented 11 months ago

I get no notifications on anything. Tried to roll this out to the team with no luck.

cwill-smg commented 9 months ago

As this is a serious blocker of using this plugin, isn't anyone interested to address this :thinking:

cosydney commented 9 months ago

As this is a serious blocker of using this plugin, isn't anyone interested to address this 🤔

Hi @cwill-smg, yes we are!! check us out at https://axolo.co. We have an opinionated way of dealing with a GitHub - Slack integration, we do a two-way sync and create an ephemeral channel for each pull request. Let us know what you think!

trezum commented 6 months ago

My team of 8 is having this issue too.

redac commented 6 months ago

Same here guys, any updates? @ashokirla

kenkendk commented 5 months ago

I would really like this too, but in the meantime I have set it up via a webhook in Github that posts to Slack. It works reasonably well, but having it integrated would be really nice.

MyNameIsOka commented 4 months ago

I wonder what needs to happen to get this functionality. It's been almost 3 years.

tcastelli commented 4 months ago

Also would like to see this working :)

drew08t commented 2 months ago

This would be very helpful.