integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
3.07k stars 481 forks source link

New Pull requests @ every reviewer in the slack channel causing mass ping spam #1360

Open kbuczynski-nashpl opened 2 years ago

kbuczynski-nashpl commented 2 years ago

I have notice that one of the slack channel I am a part of pings every reviewer (including me) when a new pull request is open. I was wondering if there is a way to remove it so it does not ping 5 people each time a PR is raised.

Any help would be appreciated

samueldg commented 2 years ago

Also seeing this behavior as of today or yesterday. Is there a configuration option to disable that feature, either at the Slack app level, or user level?

I'm already getting emails for PR review requests, so those Slack notifications are redundant.

ashokirla commented 2 years ago

Thanks for the feedback @samueldg @kbuczynski-nashpl. Yes we have just enabled this feature. The announcement will happen very soon. Apologies for the inconvenience. Right now we dont provide an option to disable mentions. Do you want to disable it for entire workspace or specific channels? Or Do you need to disable at a repo/subscription level? Or Do you want to disable only for PRs?

kbuczynski-nashpl commented 2 years ago

Disabling it on new pull request would be the best

kbuczynski-nashpl commented 2 years ago

Actualy opt out option for whole feature should be a winner

Cupofassam commented 2 years ago

@ashokirla In our use case the option to disable it for an entire workspace would work best for now. Currently I'm getting pinged in 2 Slack channels for issues I created and assigned to myself 😅

Edit to add: this is a cool feature! Keen to experiment with it down the line.

samueldg commented 2 years ago

@ashokirla Congrats on the new feature! I'm sure resolving identities between GitHub and Slack will have a lot of potential 🎉

As for my use case, I'd rather have an option to disable it entirely for a workspace, maybe until there are some finer-grained options available.

  1. App admin can opt out of Slack mentions for the whole workspace
  2. Individual users can opt in or out of Slack mentions
  3. Possible fine-tuning like:
    • Opt in or out per channel
    • Opt in or out per repo
    • Opt in or out per feature (PR, issues, comments??)

I'm mostly interested in 1. and 2. personally, because I already have a grip on my GitHub email notifications.

ashokirla commented 2 years ago

Hi all 👋 ,

Mentions will work only if you login to GitHub app in your Slack workspace. When you login to GitHub app with your GitHub id, we map it with your Slack id and ping you in Slack whenever you are mentioned in any of the GitHub notifications. If any of your team members haven't logged into the GitHub app in Slack, they will not get pinged.

And if you have multiple Slack workspaces where you use GitHub app, mentions will work only in the workspace where you login to GitHub app the latest.

And thanks for providing more details about the usecase. We will definitely work on providing more controls to fine tune the way you want mentions. Meanwhile you can use the following workaround -

If you have any other Slack workspaces that you don't use often, you can login GitHub app from there. Or you can create personal slack workspace, install GitHub app and login from there. We will only target the latest logged in workspace for mentions. So this way you will not be mentioned in your actual Slack workspace.

Thanks a lot for your Support 🙏

kbuczynski-nashpl commented 2 years ago

thanks @ashokirla for and update <3

Can we get some ETA getting more configuration option out as its impacting a lot of member in my slack space atm and workaround is very awkward for some of them

ashokirla commented 2 years ago

@kbuczynski-nashpl until we finalise the full scope of the feature, i can't provide you the ETA. But we will start the work for fine grained configuration. I will update you once we have more clear timelines.

kbuczynski-nashpl commented 2 years ago

@ashokirla its been a while Do you have any ETA for the fix ?

renny-oh commented 2 years ago

We have complaint about this mentions. ETA ? I nudge text here on 27. Jun . haven't seen any way to disable it. and Knowing ETA will help asking people do workaround or stay calm.

mrbeck02 commented 2 years ago

Checking progress on this as well. Anything to lessen the noise I get for PRs that don't involve me.

Dunedan commented 1 year ago

So this suddenly got even worse, as thanks to the recently added threading for pull request notifications not only the channel with the Github integration gets highlighted, but one gets notifications for every response in pull request threads as well. :unamused:

alyssaruth commented 1 year ago

We are also experiencing irritating slack noise as a result of recent changes to mention people and reply in threads.

One thing that makes it particularly bad is that it seems if I respond to someone else's review comments, I'm then treated as an "assignee" as far as the slack app is concerned. So when I merge the PR, I get @'d in slack to tell me what I've just done.

image image

I also use the 'Threads' view to keep tabs on discussions I'm involved in, so it sucks to have this polluted with a load of noise from our pull requests channel. Opting out of all mentions would be great - it isn't a use case we've felt the need for at all, we'd just like to go back to the nice quiet lives we had before :smile:

jarednorman commented 1 year ago

@ashokirla Any update on this? It's been ten months.

masterful commented 1 year ago

It looks like we're able to at least remove the threading using a different slash command (that I hadn't seen prior) It doesn't fix the mentions bit, though.

But given that the threading is intended to reduce noise and is ironically increasing it instead (since it posts back to the channel for some of the actions) it's possible to disable threading per-channel according to the README

/github settings

You will need to do this on a per-channel basis - but it will give you the option to disable threading: image

crazymanish commented 1 year ago

i found a way to stop slack-tagging (spamming focus)

Enjoy all GitHub notifications without tagging(spamming) you!

Screenshot 2023-01-17 at 17 21 20 (1)
RONNCC commented 1 year ago

@ashokirla wondering if any updates :-)

unicornzero commented 1 year ago

Will this feature request make it onto your product roadmap anytime soon?

steve-taylor commented 1 year ago

The impact of this integration in its current form is that it makes an entire useful Slack feature (Threads) useless.

One of the purposes of building a Slack integration is that it leads to growth in seat count. If people disable the Slack integration due to its noise, GitHub loses an important growth channel.

phil-6 commented 2 months ago

It's a year since the last comment and I'm wondering if there are any updates here?