search

integrations / slack

Bring your code to the conversations you care about with GitHub's integration for Slack
https://slack.github.com/
MIT License
3.1k stars 489 forks source link

Pull Request messages don't handle skipped actions jobs #1391

Open ColdenCullen opened 2 years ago

ColdenCullen commented 2 years ago

If a pull request Actions workflow is marked to not run (with if: false or similar), the message in slack doesn't update to show the action as being unnecessary.

For example, we have an action that runs only on dependabot PRs, so in most PRs it's skipped. In the PR page, all actions are shown to have passed, but in slack it never updates the status, and leaves it gray.

In the Actions UI: image In Slack: image (screenshots are cropped to not share confidential information)

It seems like the message should remove the "GitHub Actions: dependabot" element, and update the checks element to say "2/2 checks passed".

aasiddiq commented 2 years ago

@ashokirla can please have a look at this and suggest the next actions

gileswells commented 2 years ago

I have a similar setup where job 1 determines whether to run job 2 OR job 3, never both. This shows the same 2/3 successful checks that @ColdenCullen shows in the above screenshot.

rnsc commented 1 year ago

Hello @aasiddiq would it be possible to have an update on this? It's been several months and those updates in Slack with the yellow badge are not great.

jbnjohnathan commented 1 year ago

We also have this issue and are interested in a solution

jamesclancy commented 1 year ago

We are encountering a similar issue where:

We create a draft PR which has a 12 checks skipped. At this stage the slack PR integration shows 0/12 checks passed We change the PR to Ready for Review and the 12 checks run. At this stage the slack PR integration shows 12/24 checks passed.

wweaver commented 1 month ago

Would be nice if skipped wouldn't show. I would want them hidden. Skipped isn't bad. I'd only want to show failures.

image