integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.99k stars 468 forks source link

Unfurling on arbitrary (github pages) domains #1394

Open symbiont-daniel-speyer opened 2 years ago

symbiont-daniel-speyer commented 2 years ago

Is your feature request related to a problem? Please describe.

We have (are working on) a private Github Pages site with its own dns domain for internal documentation. When a link to this site is posted in slack, the ordinary (non-github) link unfurler does its thing and we get an unhelpful preview of github's login page.

Describe the solution you'd like

Allow me to pass the domain of our github pages to the github slackbot (already installed in our slack), either with a private message or the app config page. Then when a link to that domain is posted, the github slackbot unfurler takes it, visits the page with appropriate credentials, and returns a preview.

Describe alternatives you've considered

In theory we could run our own slackbot just to unfurl these links. This would mean leaving a server running with a publicly-routable IP and github credentials (at least browser cookies). This is a security risk we'd rather not take.

Additional context

I'm hoping that your answer will be "we already have this, you missed it in the docs [link]". Long-shot, maybe, but I can hope.

annabaker commented 2 years ago

any update on this? our team would also love this feature.

btiernay commented 1 year ago

My company also uses private GitHub Pages to host internal statically generated documentation that is highly utilized among developers. Our Slack is littered with messages that look this:

image image

Even though the backing page has some useful contextual Open Graph metadata in the meta tags. It would extremely useful to have the ability to make this metadata exposed in the Slack context to promote better communication between colleagues, while minimizing the amount of noise generated. Thank you for the consideration 🙇 .

keeferrourke commented 1 month ago

This is still a communication roadblock in May 2024 :(