integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
3.07k stars 483 forks source link

Duplicate Slack notifications for assigned team members #1442

Open TBakes opened 2 years ago

TBakes commented 2 years ago

Describe the bug We use github notifications and love them. When someone's review is requested, they get a Slack message. When a team they're on is requested, they get a notification. But, we recently tried out the Enable auto assignment feature within the team, and had some troubles. When a team is assigned, everyone on the team gets notified, THEN the individual who is selected via round-robin gets another notification. We hoped/expected for github to figure out which team member to assign, and then send a slack notification to just that team member, instead of the whole team.

atsushi-ishibashi commented 1 year ago

Even if you enable Only notify requested team members, you don't get notification via GitHub notification inbox but slack app. https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team#configuring-team-notifications

tthayer commented 9 months ago

Despite the above-mentioned setting being applied, team members are still getting notified twice via the Slack integration when automatic assignment is enabled. Is there a setting or filter I'm missing?