search

integrations / slack

Bring your code to the conversations you care about with GitHub's integration for Slack
https://slack.github.com/
MIT License
3.11k stars 489 forks source link

Pull request "ignore approved pull requests" is broken #1453

Open masad-frost opened 2 years ago

masad-frost commented 2 years ago

Pull request reminders configured in https://github.com/orgs/<org>/teams/<team>/settings/reminders/<id> do not respect Ignore approved pull requests option

Looks like this has been happening for a while, a bunch of people in this thread are seeing this issue https://github.com/integrations/slack/issues/789#issuecomment-986158825

To Reproduce Steps to reproduce the behavior:

  1. create reminder for a team
  2. have a PR that is approved and has also other pending reviews
  3. trigger reminder
  4. approved pr is included in slack message

Expected behavior no remind pls

Screenshots image

cyril-slimani commented 2 years ago

We are facing the same problem, do you have an idea when it will be solved ?

masad-frost commented 2 years ago

wish they'd open source this product

eder-wosniak-pontomais commented 2 years ago

I have the same problem!

ysk24ok commented 1 year ago

In our case, approved PRs are always excluded from the reminder even though we don't mark the option.

pocoapoco commented 1 year ago

I am facing the same problem.

erplsf commented 1 year ago

same here

swright-gaggle commented 10 months ago

Same here. I have it set to ignore approved pull requests, which for us is 2 or more approvals. I still get reminders that clutter up my channel.

maja-borzemska commented 9 months ago

I have encountered the same problem 😞

t16n commented 9 months ago

same here

jimedelstein commented 8 months ago

With our workflow this makes the feature unusable, wish we could get a fix, seems it's been broken a while now

bobbylej commented 4 months ago

I got a similar issue, as it includes one of the approved PR in the notification, but also doesn't include one with "review required" status. It looks like some random behavior.

michaelsilver commented 4 months ago

We're seeing the same issue, would love to see any updates or workarounds!