search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.99k stars 468 forks source link

Also mention the PR author in the PR discussion thread #1572

Open lachenmayer opened 1 year ago

lachenmayer commented 1 year ago

Is your feature request related to a problem? Please describe.

Hi there, loving the new threading behavior for PR discussions - has massively reduced the noise in our notifications channels. However it seems like we've reduced the noise slightly too much: PR authors no longer get notified about comments on their own PRs.

Looking at the README, this seems like expected behavior: https://github.com/integrations/slack#mentions

Describe the solution you'd like

It would be great if the PR author could be automatically mentioned in the PR message. I personally don't see why this would need to be behind a config flag, as I would expect Slack notifications on your own PRs to always be useful (happy to hear differing thoughts on this though).

Describe alternatives you've considered

I currently manually ping authors (including myself!) which is obviously not ideal.

Additional context

Let me know if you need any - hope this is clear enough.

exxocism commented 1 year ago

+1 YES! This is what I want. Thank you for uploading this 👍

deadpointdigital commented 1 year ago

Between this issue and https://github.com/integrations/slack/issues/1565, threading seems unusable in its current form.

Alice opens a PR and requests a review by Bob. A new message is posted in the relevant slack channel, which tags Bob's slack user, as he is a reviewer. Bob receives a notification (Good). Bob makes a comment on the PR. A new message is posted in a thread of the original. Bob receives a notification, but he does not need to be notified that he just posted a comment (Bad). Alice does not receive a notification that there is a comment on their PR (Very bad). Am I missing something?

rappo commented 1 year ago

+1 It would be great if the author was mentioned when a PR had changes requested if nothing else.