integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
3.06k stars 479 forks source link

Be notified only of PRs where I'm assigned as reviewer #1606

Open JordanGottardoDocplanner opened 1 year ago

JordanGottardoDocplanner commented 1 year ago

Is your feature request related to a problem? Please describe. I don't see a clear way of receiving notifications for only the PRs I am assigned to as a reviewer. I subscribed to a repo using the command /github subscribe <organization>/<repository> pulls. This will notify me whenever a PR is opened. However, I'd like to be notified only when I'm a reviewer of that PR. Since the repository is pretty big, I am being notified for PRs not concerning my work and it's very noisy.

Describe the solution you'd like Be notified only of PRs where I'm a reviewer

MM3y3r commented 1 year ago

Has this been solved?

Lp-Francois commented 1 year ago

Hello πŸ‘‹ Still not updates? πŸ˜… Especially for monorepos, seems like a standard expected feature

VivaLaPanda commented 1 year ago

+1 to this request

henryhobhouse commented 1 year ago

Also +1 on this for monorepos. Otherwise its a noisy mess and defeats the object.

yakirSalt commented 1 year ago

that would be great to have

huseyin-hamilton-cko commented 1 year ago

+1

neighborcaroline commented 1 year ago

@JordanGottardoDocplanner @huseyin-hamilton-cko @MM3y3r @VivaLaPanda @ashokirla @henryhobhouse @Lp-Francois this can be done via Scheduled Reminders! Check out our bud Rasim's blog post to learn how πŸŽ‰

andrii-motorway commented 8 months ago

https://rasim.pro/blog/personal-slack-github-notifications-for-pull-requests-reviewers-how-to-set-up/

robertojrdev commented 5 months ago

+1 also for mentions - I cannot use the Scheduled Reminders @neighborcaroline and @andrii-motorway mentioned because the organization doesn't want to set it up.

senghorn commented 4 months ago
ish-joshi commented 4 months ago

This would be super helpful! A large repo results in unnecessary notifications based on repo name only.

setvik commented 3 months ago

Would be really valuable

eric-shiu commented 3 months ago

This would be super helpful for me

oriheimlich commented 3 months ago

Will be happy for that as well

nmagedman commented 3 months ago

TL;DR "Scheduled Reminders" provides the solution you want

A solution was provided above by @neighborcaroline (and @andrii-motorway) involving "Scheduled Reminders". I initially dismissed that solution as being off-the-mark, since I wasn't looking for daily reminders -- I wanted instant notifications of new events.

However, it ought to be clarified that this solution really will enable immediate notifications, not just daily scheduled reminders. The feature is misnamed. Or rather, misconceptualized. The GitHub/Slack integration ought to be framed as a connector enabling GitHub to send messages to you via Slack. Those messages can be:

The developers at GitHub, however, conceptualized (and named) the integration specifically as a "Scheduled Reminders" feature, which -- oh, also happens to be able to send "real-time" alerts.

I can't emphasize explicitly and strongly enough that GitHub’s naming the integration "Scheduled Reminders" really masks its true value as an event notification system. The daily reminder aspect of it ought to be downplayed as a nice extra feature, not given the center-stage spotlight.

So... follow the instructions in the blog post. Add your Slack Workspace. Enable the real-time alerts. And, personally, I've disabled the daily Scheduled Reminders by unchecking all 7 days from the list, since (a) it drowned out the real-time alert message history in Slack, and (b) the real-time alerts update themselves with a ~strikethrough~ when the event is no longer relevant, so I can just look at the message history looking for non-~stricken~ alerts.

One last note: When adding the workspace, it showed a scary popup dialog re: migrating from a legacy app to the new one by uninstalling and re-installing, and it had a link to documentation that no longer exists. I was very worried about breaking things for the rest of the company. But it was fine β€” much ado about nothing β€” go ahead and add the workspace.

aleksei-kadeikin commented 2 months ago

+1

victorlee134 commented 1 month ago

+1

alankritjoshi commented 1 month ago

Why is this still an unsolved issue when github and slack are both leaders in their respective product categories?

The primary point of the integration should be to allow developers to quickly notify other reviewers and act on notifications that require their review.

I always end up installing other apps like toast, pullnotifier, etc. (which are all paid at enterprise level btw) to achieve this. The slackbot right now is all unactionable noise.

zwang1-godaddy commented 3 weeks ago

+1

eangermann-r7 commented 4 days ago

+1

gabriel-pineda commented 3 days ago

If anyone is looking for an alternative, toast and pullnotifier are great options. We've been using it to simplify our workflow, and it's been a game-changer for us.