search

integrations / slack

Bring your code to the conversations you care about with GitHub's integration for Slack
https://slack.github.com/
MIT License
3.1k stars 489 forks source link

Assignees not being @mentioned when comments/reviews added to PR #1620

Open ariJayne opened 1 year ago

ariJayne commented 1 year ago

Describe the bug Assignees not being @mentioned when comments/reviews added to PR

To Reproduce Create a PR, assign github account thats connected to integration add a comment to that PR

Expected behavior slack notification lists reviewers and assignees, with the assignee being tagged by their slack account but instead it has the tag to the github account

Screenshots Screen Shot 2023-01-31 at 6 17 43 PM

Additional context I know this has been mentioned in another closed issue and the response was that this was not possible (https://github.com/integrations/slack/issues/1362#issuecomment-1043983281) but the README doc is pretty misleading in saying that it IS possible: https://github.com/integrations/slack#mentions image

image

https://github.com/integrations/slack#mentions-in-the-slack-threads image

Please find a way to fix this feature or at least allow us to enable the PR authors to receive notifications on their own PRs. It makes no sense for them to be excluded from this and i thought the assignee would be the workaround but that doesn't even work.

felipe-linares commented 1 year ago

+1, it used to do it properly before the PRs went into threads and having this no longer mention authors sometimes slows down our workflow.

jeetmehta13 commented 1 year ago

Hello, looking into this. Thanks for raising an Issue.

cristian-moreno-ruiz commented 1 year ago

In addition to what the OP is reporting, the Author is not mentioned in the slack message either. Therefore, when the PR is approved by any reviewer, the author (who is the most interested in this case), is not notified about any activity of the PR, which is kind of loosing the point of having that integration (e.g. I'm notified when I open a PR, but since all other activity goes in a thread I'm not part of, I am not notified of the activity in my PR)

I'd appreciate you could also fix this as well!

ashokirla commented 1 year ago

It is by design. We only mention reviewers and anyone that is mentioned inside the PRs. We want to be conservative w.r.t mentions. We heard from customers about too many mentions resulting in noise. We will add this request to the backlog and look into it as part of the next iteration of improvements.

Thanks

cristian-moreno-ruiz commented 1 year ago

@ashokirla Thanks for your reply, but I think this is a bit of a miss-understanding of the feedback (I was actually complaining about too many mentions in the original integration, never happy as you can see :)).

The problem is that originally, the plugin would notify about any activity in Github, including "I open a PR", and also, "I comment on my own PR", and this is what people was complaining about. But obviously, as a software developer (and I'm sure 99% of software developers will agree), it will be useful for me to be notified about anyone commenting in the PR I opened, because then I'll need to address that feedback, either by replying and explaining my reasoning, or by applying proposed changes. What I don't want to be notified about is about my own comments, either on my PR or other's PRs, because it was me who produced that comment and don't need to be notified about it.

I hope I have properly explained the desired solution and you can take into account my input for the next iteration.

Thanks!

lcsiki commented 1 year ago

Agreed to this, I'd really like this feature implemented :+1:

jmagbanua-a2 commented 1 year ago

+1 to this

jaredparco commented 10 months ago

+1

bcg-cjpark commented 9 months ago

+1, I hope assignees @mentioned be implemented

tomaszturek commented 9 months ago

+1

cfarrend commented 8 months ago

+1

Enabling this would mean almost every GitHub notification related to pull requests could be automatically enabled in Slack as the assignee (PR author) will be notified on comments in the thread without requiring someone else to @mention them.

robin-blanchard commented 8 months ago

+1

kihara-ori commented 8 months ago

+1

iimorozov commented 8 months ago

+1

yumatsuchiya commented 7 months ago

+1

shepp-raybeam commented 6 months ago

+1

albertfc commented 6 months ago

+1

tomasgtruepath commented 6 months ago

+1

xafm commented 5 months ago

+1

GregSouza-Catapult commented 5 months ago

Without this implemented, as the Assignee for a PR, I have to manually select to subscribe to notifications to the PR thread in Slack to be alerted of comments from Reviewers

navs-github commented 1 month ago

Massive +1

"I want to be mentioned in slack if someone comments or leaves a review on any of my pull requests" is the main use-case I installed this integration for.