Notifications for Pull Request Approval

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration

https://slack.github.com/

MIT License

3.05k stars 479 forks source link

Notifications for Pull Request Approval #1622

Open CDTR-MattConroy opened 1 year ago

CDTR-MattConroy commented 1 year ago

Is your feature request related to a problem? Please describe. I am not notified when a Pull Request has been approved by a reviewer.

Describe the solution you'd like I would like to be notified when a Pull Request has been approved by a reviewer.

Manouchehri commented 1 year ago

Likewise, our team found it surprising they don't get any notifications when we review/approve PRs.

It seems like comments from the PR approval stage are also silent.

Saga4 commented 1 year ago

Did Someone found any fix to this, as earlier I used to get notifications on PR approvals.

andrewdowis commented 1 year ago

Notifications for approvals stopped working for me after June 14, 2023. The heck?

Tagussan commented 1 year ago

Any updates for this?

badele commented 7 months ago

We have same issue, is the issue is confirmed by github team ?

navarrojava commented 4 months ago

lee-40square commented 4 months ago

Such an important thing to show. any update?

gamue commented 2 months ago

It's still working fine for me, however think the setting is not very intentional placed under Profile -> Settings -> Scheduled Reminders -> Enable real-time alerts. I'm not using the scheduled reminder but think this section and step is required to authorize GitHub into the Slack workspace

HadesSik commented 1 month ago

Does subscribing to reviews trigger notifications? I'm wondering if notifications still aren't coming through.

mrtns commented 3 weeks ago