search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
3k stars 469 forks source link

Can't subscribe to Workflows that have whitespace in the name #1639

Open antdking opened 1 year ago

antdking commented 1 year ago

Describe the bug We have workflow names that contain spaces (ie name: "release: python-client").

We're now no longer able to subscribe to these workflows.

To Reproduce Steps to reproduce the behavior:

/github subscribe <org>/<repo> workflows:{name:"release: python-client"}

This responds with:

This channel will receive notifications from <org>/<repo> for:
workflows:{name:"release:python-client"}

Note the whitespace has been stripped in the response.

Expected behavior A clear and concise description of what you expected to happen.

  1. Workflow Notifications show for the specified workflows when they run
  2. /github subscribe list features should show the correct "subscription", containing whitespace in the name

Desktop (please complete the following information):

Additional context This was working on initial release. Our notifications are now broken with no way to reconfigure following some renames for cleanup

kmaraz commented 2 months ago

Hi, what's the recommended solution right now please? Should we just rename our workflows? It has been more that a year from the task being assignes to @meghnasavit .