integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
3k stars 469 forks source link

include approval comments in approval notifications #1661

Open jmhodges-color opened 1 year ago

jmhodges-color commented 1 year ago

Is your feature request related to a problem? Please describe.

I love getting DMs I get from this app when my PR gets a code review approval. There is one extra thing that would be helpful. When I get an code review approval (or send someone else one), folks sometimes say helpful things like "Oh, is there a ticket for the thing you mentioned you aren't doing in this PR?" or whatever

But those don't show up in my Slack notification of the approval, only the approval does. So then I (or others) ignorantly just merge things without noticing (we even have automerge when enough approvals happen, so we may never open the PR again) and never go look at the body of the approval message

Describe the solution you'd like Include the messages people write when they're sending an approval

Describe alternatives you've considered Reading the PR even if it auto-merged

Additional context I really like this tool quite a lot and I'm grateful y'all give time to it. It's saved me a lot of hassle.