search

integrations / slack

Bring your code to the conversations you care about with the GitHub and Slack integration
https://slack.github.com/
MIT License
2.99k stars 468 forks source link

GitHub Slack Integration App - Unable To Sign In Through Enterprise SSO #1727

Open Jingsong-Chen opened 12 months ago

Jingsong-Chen commented 12 months ago

Describe the bug My company purchases the GitHub enterprise solution and has its own GitHub domain. If I try to sign in through github.com, I will get an error message saying my email is not found. I have to visit the custom domain and sign in through my company's SSO to log in to my work GitHub account.

So currently, on my Slack, I logged in with my company account. I also downloaded the GitHub Slack app. The "Connect GitHub account" button of the slack app takes me to a standard login page, through which I cannot complete my login. It should take me to log in through a custom domain. Thanks!

To Reproduce Steps to reproduce the behavior:

  1. Go to the GitHub app in slack
  2. type /github signin
  3. Click on the green "Connect GitHub account" button
  4. Gets redirected to the GitHub login page, which won't work for my work GitHub account login
  5. Enter work GitHub email account
  6. See "invalid account" error.

Expected behavior Be able to log in through my company's custom GitHub enterprise domain, which will prompt me to log in through our SSO instead of through github.com, which won't recognize my work account.

Desktop (please complete the following information):

RishabLokray1995 commented 10 months ago

any update on this ? i am facing the same error. @Jingsong-Chen @snankani

WebDevJoshB commented 9 months ago

Any update? I encountered this issue just now.

RishabLokray1995 commented 9 months ago

Still cant use it

Regards Rishab Lokray Backend Dev @.***

From: Joshua Blauvelt @.> Sent: Wednesday, September 20, 2023 8:12:47 AM To: integrations/slack @.> Cc: Lokray, Rishab @.>; Comment @.> Subject: Re: [integrations/slack] GitHub Slack Integration App - Unable To Sign In Through Enterprise SSO (Issue #1727)

External Email

Any update? I encountered this issue just now.

— Reply to this email directly, view it on GitHubhttps://github.com/integrations/slack/issues/1727#issuecomment-1727927179, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BABWAPILRMCP3354U2ULW4DX3MBW7ANCNFSM6AAAAAA2JEORSU. You are receiving this because you commented.Message ID: @.***>

renanz commented 7 months ago

Any update?